Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressing "automatic module" warning for benchmark-jmh #13997

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

viswanathk
Copy link
Contributor

jmh.core is not modularized resulting in this error. The other modules seem fine though.

Probably can be removed once jmh updates the module-info.

Closes #13992

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@msokolov
Copy link
Contributor

ooh, thanks this has been an annoyance for a while now!

@msokolov msokolov merged commit a0e1eee into apache:main Nov 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange javac "automatic module" warning for benchmark-jmh
3 participants